Percy test #415
Closed
Percy test #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automated Percy visual regression testing to GitHub Actions workflow with intelligent partial snapshot detection for faster builds. Features: - Automatic component change detection from git diff - Partial snapshots for changed components only - Full snapshots for global changes (tokens, variables, mixins) - PR blocking until Percy approval - Auto-approval on main branch for baseline updates - Path filtering to skip non-Skin changes Changes: - Add Percy GitHub Actions workflow (.github/workflows/percy.yml) - Add change detection script (packages/skin/scripts/detect-changed-components.js) - Update CONTRIBUTING.md with automated workflow documentation - Add PERCY-FAQ.md for comprehensive user guidance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The Percy workflow was failing with "fatal: ambiguous argument 'main...HEAD'" because the checkout action only fetches the PR branch. Added explicit fetch of the main branch to ensure git diff comparison works correctly. Co-Authored-By: Claude <noreply@anthropic.com>
HenriqueLimas
force-pushed
the
percy-test
branch
from
92f524b to
5a281e8
Compare
Added automated Percy build status reporting that: - Waits for Percy builds to complete processing - Posts informative PR comments with build status and link - Warns if visual changes are detected but doesn't block PRs - Only fails workflow if Percy build encounters errors Changes: - Added @octokit/rest dependency for GitHub API integration - Created percy-wait-and-comment.js script to monitor builds - Updated Percy workflow to post build status comments - Uses PERCY_READ_TOKEN to query build information The script dynamically fetches the Percy project slug and finds builds by commit SHA, eliminating need for hardcoded configuration. Co-Authored-By: Claude <noreply@anthropic.com>
HenriqueLimas
force-pushed
the
percy-test
branch
from
a09a615 to
c269394
Compare
HenriqueLimas
force-pushed
the
percy-test
branch
from
c269394 to
6998af4
Compare
- Create sass-dependency-analyzer.js to parse @use/@forward directives - Build forward and reverse dependency graphs - Find transitive dependencies when SCSS files change - Integrate dependency analysis into detect-changed-components.js - Fail-safe to "all" if dependency analysis encounters errors Co-Authored-By: Claude <noreply@anthropic.com>
HenriqueLimas
force-pushed
the
percy-test
branch
from
6998af4 to
ca85a48
Compare
The Percy API /projects endpoint returns the project data directly at response.data, not response.data.data. This was causing the "Invalid response from Percy API" error in the GitHub Action. Co-Authored-By: Claude <noreply@anthropic.com>
HenriqueLimas
force-pushed
the
percy-test
branch
from
ca85a48 to
24d2a91
Compare
Contributor
🎨 Percy Visual Regression ReportBuild Status: Summary
Generated by Percy CI • Commit 24d2a91 |
Contributor
🎨 Percy Visual Regression ReportBuild Status: Summary
Generated by Percy CI • Commit 7c6957c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for testing the GH action. The original PR is #414